-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide test proxy credentials for functional tests #6145
Comments
Are we sure the tests won't create a very large volume of requests? What's expected? |
@jakubgs I can't promise anything about the usage 😐. But right now this is blocking functional test runs. We will eventually, but it's not fast:
|
I see, that's fair, and indeed in a perfect world we'd mock everything, but it's understandable this is the simplest approach. @mendelskiv93 could you please ensure the But I would recommend creating a separate username and password for this purpose: So it's easier to revoke this access in the future when we will probably create separate |
@igor-sirotin Is there a way we can do:
like in status-mobile and status-desktop? |
@mendelskiv93 if these are already available in |
@igor-sirotin yes they are! |
@mendelskiv93 just in case, did you create separate credentials for this purpose? This case is dangerous because we could potentially (but we'll prevent it as much as possible) leak the key in logs. So we must have dedicated username/password for simple revoke/rotate later. |
@igor-sirotin yes I did, it will be used only by |
We need test proxy credentials in the functional tests. In the future we'll mock the providers, but we can't do it quickly right now.
Functional tests will expect these env vars:
STATUS_PROXY_USER
STATUS_PROXY_PASSWORD
Tests side done here:
The text was updated successfully, but these errors were encountered: