Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flowType missing for UserProfileCreatePassword and UserProfileConfirmPassword #6183

Open
glitchminer opened this issue Dec 9, 2024 · 1 comment · May be fixed by #6188
Open

flowType missing for UserProfileCreatePassword and UserProfileConfirmPassword #6183

glitchminer opened this issue Dec 9, 2024 · 1 comment · May be fixed by #6188
Assignees
@qfrank
Labels
bug core-team metrics
Milestone
2.32.0

Comments

@glitchminer
Copy link
Contributor

flowType is being logged as *** for 2 screens during the new keys onboarding flow.

DEBUG    RequestLogger    call    {"method": "addCentralizedMetric", "duration": "212.958µs", "request": [{"metric":{"appVersion":"2.32.0-rc.3","eventName":"navigation","eventValue":{"flowType":"***","viewId":"UserProfileCreatePassword"}

DEBUG    RequestLogger    call    {"method": "addCentralizedMetric", "duration": "161.833µs", "request": [{"metric":{"appVersion":"2.32.0-rc.3","eventName":"navigation","eventValue":{"flowType":"***","viewId":"UserProfileConfirmPassword"}

@qfrank @igor-sirotin , identified as likely being related to this function:

status-go/mobile/callog/status_request_log.go

Lines 105 to 111 in cdc41c3

func removeSensitiveInfo(jsonStr string) string {
// see related test for the usage of this function
return sensitiveRegex.ReplaceAllStringFunc(jsonStr, func(match string) string {
parts := sensitiveRegex.FindStringSubmatch(match)
return fmt.Sprintf(`%s:"***"`, parts[1])
})
}

@glitchminer glitchminer added this to the 2.32.0 milestone Dec 9, 2024
@qfrank qfrank self-assigned this Dec 10, 2024
@qfrank qfrank linked a pull request Dec 10, 2024 that will close this issue
Open
@qfrank
Copy link
Contributor

qfrank commented Dec 11, 2024

Hi @glitchminer , could you help check if #6188 fixed the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qfrank qfrank

Labels
bug core-team metrics
Projects
Status Desktop/Mobile Board
Status: No status
Milestone
2.32.0
Development

Successfully merging a pull request may close this issue.

fix_: correct sensitive regex status-im/status-go
2 participants
@qfrank @glitchminer