chore(block)!: remove desktop BlockContact function for parity #6172
+2
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
osmaczko,
qfrank,
Parveshdhull and
igor-sirotin
and removed request for
osmaczko and
qfrank
|
Looks like you have BREAKING CHANGES in your PR. Check-list
|
Jenkins Builds
|
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6172 +/- ##
===========================================
+ Coverage 61.22% 61.25% +0.02%
===========================================
Files 833 833
Lines 109910 109895 -15
===========================================
+ Hits 67295 67316 +21
+ Misses 34746 34723 -23
+ Partials 7869 7856 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Parveshdhull
approved these changes
Dec 5, 2024
igor-sirotin
approved these changes
Dec 5, 2024
osmaczko
approved these changes
Dec 5, 2024
Needed for status-im/status-desktop#16640 In Desktop, we still used a "forked" version of the BlockContact function that had as differences that it didn't leave the chat nor delete the messages. However, we want to have parity now and those features, so it makes no sense to use a different function. This is a breaking change because it removes an API, but I took care of removing the use of that function in the Desktop app and Mobile never used it, so it's an inoffensive breaking change. Additionally, I added the notifications to the messenger response.
jrainville
force-pushed
the
fix/dekstop-block-contact-delete-messages
branch
from
db71074 to
3b06014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-desktop#16640
In Desktop, we still used a "forked" version of the BlockContact function that had as differences that it didn't leave the chat nor delete the messages.
However, we want to have parity now and those features, so it makes no sense to use a different function.
This is a breaking change because it removes an API, but I took care of removing the use of that function in the Desktop app and Mobile never used it, so it's an inoffensive breaking change.
Additionally, I added the notifications to the messenger response.