-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet-community)_: Move community minting airdrop to router #6196
Draft
saledjenic
wants to merge
4
commits into
develop
Choose a base branch
from
move-community-minting-airdrop-to-router
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quests package `DeploymentParameters` and `DeploymentDetails` types moved from `communitytokens` package to `requests` of the wallet service.
…outer - new file `contracts/community-tokens/contracts.go` added to unify contracts creation - the following community related path processors added: - `CommunityBurnProcessor` - `CommunityDeployAssetsProcessor` - `CommunityDeployCollectiblesProcessor` - `CommunityDeployOwnerTokenProcessor` - `CommunityMintTokensProcessor` - `CommunityRemoteBurnProcessor` - `CommunitySetSignerPubKeyProcessor` - `SendType` extended with appropriate options - added endpoints to duplicated `communitytokens` api: - `StoreDeployedCollectibles` - `StoreDeployedOwnerToken` - `StoreDeployedAssets` - removed endpoints from duplicated `communitytokens` api: - `DeployCollectibles` - `DeployOwnerToken` - `ReTrackOwnerTokenDeploymentTransaction` - `DeployAssets` - `DeployCollectiblesEstimate` - `DeployAssetsEstimate` - `DeployOwnerTokenEstimate` - `EstimateMintTokens` - `EstimateRemoteBurn` - `EstimateBurn` - `EstimateSetSignerPubKey` - `NewOwnerTokenInstance` - `NewCommunityTokenDeployerInstance` - `NewCommunityOwnerTokenRegistryInstance` - `NewCollectiblesInstance` - `NewAssetsInstance` - `MintTokens` - `RemoteBurn` - `GetCollectiblesContractInstance` - `GetAssetContractInstance` - `Burn` - `SetSignerPubKey`
Jenkins Builds
|
saledjenic
changed the title
Move community minting airdrop to router
chore(wallet-community)_: Move community minting airdrop to router
Dec 11, 2024
We require commits to follow the Conventional Commits, but with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about moving community-related txs to the wallet router and aligning the sending flow across the app.
The second commit just duplicated the current
communitytokens
package and all changes in this PR are done based on that duplicated package.Once all is done, clients adapted to these changes and tested will be another PR about removing old package.
Changes done here:
new file
contracts/community-tokens/contracts.go
added to unify contracts creationthe following community related path processors added:
CommunityBurnProcessor
CommunityDeployAssetsProcessor
CommunityDeployCollectiblesProcessor
CommunityDeployOwnerTokenProcessor
CommunityMintTokensProcessor
CommunityRemoteBurnProcessor
CommunitySetSignerPubKeyProcessor
SendType
extended with appropriate optionsadded endpoints to duplicated
communitytokens
API:StoreDeployedCollectibles
StoreDeployedOwnerToken
StoreDeployedAssets
removed endpoints from duplicated
communitytokens
API:DeployCollectibles
DeployOwnerToken
ReTrackOwnerTokenDeploymentTransaction
DeployAssets
DeployCollectiblesEstimate
DeployAssetsEstimate
DeployOwnerTokenEstimate
EstimateMintTokens
EstimateRemoteBurn
EstimateBurn
EstimateSetSignerPubKey
NewOwnerTokenInstance
NewCommunityTokenDeployerInstance
NewCommunityOwnerTokenRegistryInstance
NewCollectiblesInstance
NewAssetsInstance
MintTokens
RemoteBurn
GetCollectiblesContractInstance
GetAssetContractInstance
Burn
SetSignerPubKey