Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for overlapping elements on Swap input page #22207

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix for overlapping elements on Swap input page #22207

wants to merge 1 commit into from
+6 −1

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Feb 27, 2025

Fixes #22195

Platforms

  • Android
  • iOS

status: ready

@alwx alwx self-assigned this Feb 27, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Feb 27, 2025 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6568058 #1 2025-02-27 22:42:09 ~4 min tests 📄log
✔️ 6568058 #1 2025-02-27 22:45:54 ~8 min android-e2e 🤖apk 📲
✔️ 6568058 #1 2025-02-27 22:46:52 ~9 min android 🤖apk 📲
✔️ 6568058 #1 2025-02-27 22:48:14 ~10 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 14
Failed tests: 1
Expected to fail tests: 0
Passed tests: 13

IDs of failed tests: 702843

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 1: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]`
    Device 1: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:388: in test_community_message_edit
    self.errors.verify_no_errors()
base_test_case.py:179: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 2: Message is not edited



    Device sessions

    Passed tests (13)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_swap_flow_mainnet, id: 741555
    2. test_wallet_add_remove_regular_account, id: 727231
    3. test_wallet_balance_mainnet, id: 740490
    4. test_wallet_bridge_flow_mainnet, id: 741612
    5. test_wallet_send_flow_mainnet, id: 741554

    Class TestWalletCollectibles:

    1. test_wallet_send_collectible, id: 741840
    2. test_wallet_collectibles_balance, id: 741839
    3. test_wallet_collectible_send_from_expanded_info_view, id: 741841

    @VolodLytvynenko VolodLytvynenko self-assigned this Feb 28, 2025
    @vkjr
    Copy link
    Contributor

    vkjr commented Feb 28, 2025

    @alwx, after merging this one, would you mind to create a PR based on release branch and cherry-pick changes there? 🙏

    @VolodLytvynenko
    Copy link
    Contributor

    @alwx The overlapping elements issue still exists on small-resolution devices. I think it would be better to get the UI team's opinion on this here https://discord.com/channels/1210237582470807632/1274068685266489434/1345050333554016357. In my view, the swap interface is too cluttered with elements, making it challenging to display everything properly on smaller devices

    Image

    Image

    Device:

    IOS: SE, 2020

    @VolodLytvynenko
    Copy link
    Contributor

    @alwx Alisher has already added a new design, but it still needs approval from @pedro-et and @shivekkhurana.

    Additionally, I've encountered another issue related to small device resolutions. Would it be possible to address this within the current PR, or would it be better to track it separately?

    Issue: The swap button overlaps with other elements on the swap page.

    image

    device

    • iPhone mini 13, IOS 17

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @clauxx clauxx Awaiting requested review from clauxx

    Assignees

    @alwx alwx

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa
    Projects
    Pipeline for QA
    Status: IN TESTING
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Overlapping elements on Swap input page on device with small screen
    6 participants
    @alwx @status-im-auto @vkjr @VolodLytvynenko @ilmotta @shivekkhurana