Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Dummy "Receiving on progress, stay tuned" page #15

Open
takagiwa opened this issue Feb 11, 2021 · 3 comments
Open

[Enhancement] Dummy "Receiving on progress, stay tuned" page #15

takagiwa opened this issue Feb 11, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed wip Work in progress

Comments

@takagiwa
Copy link

Hello,

This is not important.
It will help me if there are dummy index.html that shows "Receiving" before generate index.php.
Maybe copy that just after "mkdir -p ${WBASE}" in sat.sh .

Best regards,

@stdevPavelmc
Copy link
Owner

Every Bit counts and it's important.

You are absolutely right, a "Receiving..." page will tell the user that there is a process going on.

A 1 minute reload trigger will update it until the final page is ready, and that is easy to implement.

Good catch!

@stdevPavelmc stdevPavelmc self-assigned this Feb 12, 2021
@stdevPavelmc stdevPavelmc added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 12, 2021
@stdevPavelmc stdevPavelmc changed the title dummy page [Enhancement] Dummy "Receiving on progress, stay tuned" page Feb 14, 2021
@takagiwa
Copy link
Author

Hello

I think you already did that.
If not,

  1. make new html file as "/etc/sat_data/inprogress.html".
  2. add "cp "${CONFPATH}/inprogress.html" "${WBASE}/index.html" just after "mkdir -p ${WBASE}"
  3. add "rm "${WBASE}/index.html" just before "cp "${CONFPATH}/index.php" "${WBASE}/"

seems worked.

Best regards,

@stdevPavelmc
Copy link
Owner

Yep, that's the intended way, I was crafting a nice looking and mobile friendly loading page but family issues on the weekend make me stop to work on this.

I have a branch open for this locally, no worry, it will came up on the week.

@stdevPavelmc stdevPavelmc added this to the v1.0.0 release milestone Mar 5, 2021
@stdevPavelmc stdevPavelmc added the wip Work in progress label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed wip Work in progress
Projects
None yet
Development

No branches or pull requests

2 participants