Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add C implementation for @stdlib/math/base/assert/is-negative-integer #1761

Closed
3 tasks done
Rejoan-Sardar opened this issue Mar 7, 2024 · 6 comments · Fixed by #1820
Closed
3 tasks done

[RFC]: add C implementation for @stdlib/math/base/assert/is-negative-integer #1761

Rejoan-Sardar opened this issue Mar 7, 2024 · 6 comments · Fixed by #1820
Assignees
@Rejoan-Sardar
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Rejoan-Sardar
Copy link
Contributor

Rejoan-Sardar commented Mar 7, 2024 •
edited by kgryte
Loading

Description

This RFC proposes adding a C implementation for @stdlib/math/base/assert/is-negative-integer.

Related Issues

Related issues #649.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Rejoan-Sardar
Copy link
Contributor Author

I would like to work on this.

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

@kgryte kgryte changed the title [RFC]: Add C implementation for @stdlib/math/base/assert/is-negative-integer [RFC]: add C implementation for @stdlib/math/base/assert/is-negative-integer Mar 7, 2024
@kgryte
Copy link
Member

kgryte commented Mar 7, 2024

@Rejoan-Sardar Thank you for posting this RFC. Feel free to submit a PR implementing this feature.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. RFC Request for comments. Feature requests and proposed changes. Good First Issue A good first issue for new contributors! labels Mar 7, 2024
@Shashankss1205
Copy link
Contributor

If this isn't done yet, I am willing to contribute as I already understand this well. @kgryte

@Rejoan-Sardar
Copy link
Contributor Author

@Shashankss1205 almost done.I will make my PR.

@Shashankss1205
Copy link
Contributor

Ok sure.

@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 10, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Mar 11, 2024
@Rejoan-Sardar @Planeshifter
feat: add C implementation for math/base/assert/is-negative-integer
c66d855 
PR-URL: #1820
Closes: #1761

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rejoan-Sardar Rejoan-Sardar

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/assert/is-negative-integer
4 participants
@kgryte @stdlib-bot @Rejoan-Sardar @Shashankss1205