Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing Mockingjay with OHHTTPStubs, or forking Mockingjay #39

Closed
brendanlensink opened this issue Feb 3, 2020 · 1 comment
Closed

Consider replacing Mockingjay with OHHTTPStubs, or forking Mockingjay #39

brendanlensink opened this issue Feb 3, 2020 · 1 comment
Assignees
@sakuraehikaru

Comments

@brendanlensink
Copy link
Collaborator

#31 mentions some trouble with adding SPM support due to Mockingjay not supporting it.

Mockingjay doesn't seem like it's being actively maintained (kylef/Mockingjay#98), so we should consider either moving off of it (the author of Mockingjay recommends OHHTTPStubs or forking it and adding our own SPM support.
@brendanlensink brendanlensink mentioned this issue Feb 3, 2020
Merged
@sakuraehikaru sakuraehikaru self-assigned this Feb 4, 2020
sakuraehikaru pushed a commit that referenced this issue Feb 7, 2020
Rename to Netable, #38, #39
0a11459 
- Also consolidated iOS and Mac targets
- Removed MockingJay and updated unit tests using OHHTTPStubs
sakuraehikaru pushed a commit that referenced this issue Feb 11, 2020
Merge pull request #40 from steamclock/jc/38-rename-and-consolidate-t…
76ba700 
…argets

Rename to Netable, #38, #39
@sakuraehikaru
Copy link

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakuraehikaru sakuraehikaru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendanlensink @sakuraehikaru