Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to CCing all email addresses listed in commit message #47

Open
berrange opened this issue May 4, 2018 · 1 comment
Open

Default to CCing all email addresses listed in commit message #47

berrange opened this issue May 4, 2018 · 1 comment

Comments

@berrange
Copy link

berrange commented May 4, 2018

IIUC, when sending emails, the default CC list is found by looking at combination of Signed-off-by tags in the commit message, and results of an external script (eg qemu's get_maintanier.pl)

There are quite a few other commit message tags that are in common use - acked-by, reported-by, tested-by, reviewed-by and suggested-by in particular.

Here is info from QEMU's git history:

2949 acked-by:
1 acked-off-by:
5 analyzed-by:
3 approximately-suggested-by:
4 co-authored-by:
1 edited-by:
2 eviewed-by:
1 fine-with-me'd-by:
1 fix-suggested-by:
3 found-by:
1 inspired-by:
1 original-patch-by:
1 problem-spotted-by:
2 proposed-by:
2 rebased-by:
1 release-acked-by:
1 reported-and-analyzed-by:
3 reported-and-tested-by:
1686 reported-by:
1 reportyed-by:
7 requested-by:
2 reveiwed-by:
1 revieed-by:
1 revieved-by:
5 reviewd-by:
27289 reviewed-by:
1 reviewed-by::
2 reviewed-off-by:
3 reviwed-by:
1 rported-by:
1 sgined-off-by:
1 sigend-off-by:
1 signed-by:
1 signed-of-by:
5 signed-off
91069 signed-off-by:
1 signer-off-by:
4 singed-off-by:
1 spotted-by:
583 suggested-by:
1669 tested-by:
1 tested-off-by:
1 xsigned-off-by:

I would like to suggest that instead of only looking for S-o-B, it look for anything matching

XXXXXXX-by: name <email>

For any value of XXXXX - these tags are being added by patch authors because the person listed had some input on the work, so these people should be CC'd on the patch postings IMHO.

@stefanha
Copy link
Owner

stefanha commented May 6, 2018

Nice idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants