Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when choosing "[s] Select patches to send (default: all)" #49

Open
libvirtmirror opened this issue Jun 15, 2018 · 2 comments
Open

Comments

@libvirtmirror
Copy link

I get a traceback when entering 's' in the menu:

$ git publish
Stopping so you can inspect the patch emails:
  cd /tmp/tmp06j47hq2

..snip...

[c] Edit Cc list in editor (save after edit)
[t] Edit To list in editor (save after edit)
[e] Edit patches in editor
[s] Select patches to send (default: all)
[p] Print final email headers (dry run)
[a] Send all
[q] Cancel (quit)
s
Traceback (most recent call last):
  File "/usr/bin/git-publish", line 814, in <module>
    sys.exit(main())
  File "/usr/bin/git-publish", line 780, in main
    options.override_cc)
  File "/usr/bin/git-publish", line 479, in inspect_menu
    listfile.write("\n".join(patches))
  File "/usr/lib64/python3.6/tempfile.py", line 483, in func_wrapper
    return func(*args, **kwargs)
TypeError: a bytes-like object is required, not 'str'

@libvirtmirror
Copy link
Author

This was using git-publish-1.4.3-1.fc28.noarch

@stefanha
Copy link
Owner

Thanks for reporting this bug. It has been fixed:
f1ef29d

A new release will be published in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants