Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black rectangle u+25ac #108

Open
clort81 opened this issue Oct 12, 2021 · 2 comments
Open

Add black rectangle u+25ac #108

clort81 opened this issue Oct 12, 2021 · 2 comments
Labels
feature request New feature or request

Comments

@clort81
Copy link

clort81 commented Oct 12, 2021

While not strictly a 'block drawing character', the 'black rectangle u+25ac is a nice addition to thin and thick horizontal lines.
▬ ... ─ ━  
I added to tiv.cpp
0x00fff000, 0x25ac, // Black rectangle < Clort >
0x00ffff00, 0x25ac, // Black rectangle < Clort >
0x000fff00, 0x25ac, // Black rectangle < Clort >
(the extra matches allow it to 'hit' more of those middle lines)

@clort81 clort81 added the feature request New feature or request label Oct 12, 2021
@stefanhaustein
Copy link
Owner

I wonder if we should auto-generate extra matches for some characters by shifting by one pixel in configurable directions...

That said, I had thin lines enabled before and they often look quite out of place, as they show more fine-grained structure that isn't available elsewhere...

@clort81
Copy link
Author

clort81 commented Oct 15, 2021

i prefer to disable thin lines also ╷ ─ ┏ don't work well imo.

to get nice results I usually use the 'warp' tool in GIMP to shift regions so they align well.

I'd like to experiment with a random-shifter-of-source-image regions, and some Neural Network on the backend, scoring/judging how true to ground truth the result scores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants