Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDNode.dist returns squared distance while search_nn_dist requires euclidean distance #53

Open
MichaelSuen-thePointer opened this issue May 18, 2023 · 1 comment
Open

KDNode.dist returns squared distance while search_nn_dist requires euclidean distance #53

MichaelSuen-thePointer opened this issue May 18, 2023 · 1 comment

Comments

@MichaelSuen-thePointer
Copy link

MichaelSuen-thePointer commented May 18, 2023 •
edited
Loading

The two lines below, one requires dist to be euclidean distance, and the other requires it to be squared distance:
https://github.com/stefankoegl/kdtree/blob/master/kdtree.py#L501
https://github.com/stefankoegl/kdtree/blob/master/kdtree.py#L508

And the best argument is not used
https://github.com/stefankoegl/kdtree/blob/master/kdtree.py#L517
@Ar-Kareem
Copy link

Fixed 6 years ago in #43... Only a matter of time before It's merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSuen-thePointer @Ar-Kareem