From efc21e05d530d779935e515a1e9f896b3f81b15e Mon Sep 17 00:00:00 2001 From: rrajesh Date: Fri, 20 Oct 2023 15:53:55 +0530 Subject: [PATCH] [YUNIKORN-2052] Logging Enhancement for Preemption (#678) Closes: #678 Signed-off-by: Manikandan R --- pkg/scheduler/objects/preemption.go | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/pkg/scheduler/objects/preemption.go b/pkg/scheduler/objects/preemption.go index 879800f8b..1dc43d894 100644 --- a/pkg/scheduler/objects/preemption.go +++ b/pkg/scheduler/objects/preemption.go @@ -548,14 +548,20 @@ func (p *Preemptor) TryPreemption() (*Allocation, bool) { victimQueue.IncPreemptingResource(victim.GetAllocatedResource()) victim.MarkPreempted() log.Log(log.SchedPreemption).Info("Preempting task", - zap.String("applicationID", victim.GetApplicationID()), - zap.String("allocationKey", victim.GetAllocationKey()), - zap.String("nodeID", victim.GetNodeID()), - zap.Stringer("resources", victim.GetAllocatedResource())) + zap.String("askApplicationID", p.ask.applicationID), + zap.String("askAllocationKey", p.ask.allocationKey), + zap.String("askQueue", p.queue.Name), + zap.String("victimApplicationID", victim.GetApplicationID()), + zap.String("victimAllocationKey", victim.GetAllocationKey()), + zap.Stringer("victimAllocatedResource", victim.GetAllocatedResource()), + zap.String("victimNodeID", victim.GetNodeID()), + zap.String("victimQueue", victimQueue.Name), + ) } else { log.Log(log.SchedPreemption).Warn("BUG: Queue not found for preemption victim", - zap.String("applicationID", victim.GetApplicationID()), - zap.String("allocationKey", victim.GetAllocationKey())) + zap.String("queue", p.queue.Name), + zap.String("victimApplicationID", victim.GetApplicationID()), + zap.String("victimAllocationKey", victim.GetAllocationKey())) } }