Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PD] Fix indention #1635

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[PD] Fix indention #1635

merged 1 commit into from
Feb 21, 2025

Conversation

JiahuiWho
Copy link
Contributor

@JiahuiWho JiahuiWho commented Feb 21, 2025 •
edited
Loading

As title 😭

Tested with helm template --debug --dry-run

philipliu
philipliu approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if our CI could catch this. Do you think you can add a step to check the helm charts? I think we can start with running helm template to catch the simplest issues.

@JiahuiWho
Copy link
Contributor Author

Track in https://stellarorg.atlassian.net/browse/ANCHOR-972

@JiahuiWho JiahuiWho merged commit eb78388 into stellar:develop Feb 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipliu philipliu philipliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiahuiWho @philipliu