Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC endpoint getTransactions should accept startLedger and pagination, not hash #927

Closed
janewang opened this issue Jul 24, 2024 · 2 comments · Fixed by #911
Closed

RPC endpoint getTransactions should accept startLedger and pagination, not hash #927

janewang opened this issue Jul 24, 2024 · 2 comments · Fixed by #911
Assignees
Labels

Comments

@janewang
Copy link
Contributor

janewang commented Jul 24, 2024

What version are you using?

RPC getTransactions on Lab v2 is shown here.

getTransactions is a way to pull back multiple transactions, so it needs startLedger number and pagination. It currently accepts a transaction hash which make sense for pulling back a single transaction, not multiple transactions.

The API documentation for getTransactions (plural) is here. It should not be confused with getTransaction (singular).

@janewang janewang added this to DevX Jul 24, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DevX Jul 24, 2024
@quietbits quietbits moved this from Backlog to Todo in DevX Jul 24, 2024
@quietbits quietbits moved this from Todo to In Progress in DevX Jul 24, 2024
@quietbits quietbits assigned jeesunikim and unassigned quietbits Jul 24, 2024
@quietbits quietbits linked a pull request Jul 24, 2024 that will close this issue
@jeesunikim jeesunikim moved this from In Progress to Needs Review in DevX Jul 29, 2024
@jeesunikim
Copy link
Contributor

Please see the latest here

@jeesunikim jeesunikim moved this from Needs Review to Done in DevX Jul 30, 2024
@janewang
Copy link
Contributor Author

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants