Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-10: Use hostname & port only when validating challenge transactions #210

Open
JakeUrban opened this issue Jul 19, 2021 · 3 comments
Open

Comments

@JakeUrban
Copy link
Contributor

What problem does your feature solve?

The demo wallet uses the URL entered into the UI when validating an anchor's challenge transaction. This is an issue when the user enters the protocol (http:// and https://) for the anchor's home domain. Since the home domains assigned to the issuing accounts don't include protocols, we get the following error:

Invalid homeDomains: the transaction's operation key name does not match the expected home domain

You can reproduce by going to the demo wallet and adding SRT with the home domain "https://testanchor.stellar.org", then initiating a SEP-24 deposit.

What would you like to see?

The demo wallet should only use the hostname (and if present, port) of the home domain URL entered into the UI for the asset when validating challenge transactions.

@RobertStuff
Copy link

Hi @JakeUrban Im having trouble with this one with django polaris. how to address this? thanks

@JakeUrban
Copy link
Contributor Author

@RobertStuff don't enter the protocol (http/https) when adding the asset to the demo wallet. The URL should match the hostname & port of the HOST_URL environment variable set in Polaris.

@RobertStuff
Copy link

@JakeUrban Thanks it works..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants