Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DockerBuilder): implement .dockerignore like behaviour #30

Open
nokome opened this issue Oct 25, 2018 · 1 comment
Open

feat(DockerBuilder): implement .dockerignore like behaviour #30

nokome opened this issue Oct 25, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@nokome
Copy link
Member

nokome commented Oct 25, 2018

Currently we send all files in the folder to the Docker daemon as a build context, with a few exceptions:

https://github.com/stencila/dockter/blob/v0.2.6/src/DockerBuilder.ts#L61

It would also be sensible to ignore node_modules etc. See https://codefresh.io/docker-tutorial/not-ignore-dockerignore/

@nokome nokome added the enhancement New feature or request label Oct 25, 2018
@giorgiosironi
Copy link

This is language-specific, but as you say lots of conventions-based folders like node_modules could be excluded.

@nokome nokome added this to the 1.x milestone Nov 12, 2018
@nokome nokome removed this from the 1.1 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants