chore(typescript): update typescript to version 5.9.2 (#6397)

* chore(typescript): update typescript to version 5.9.2

Fix new type errors. Add types array to tsconfig.json to fix a new
issue with dts-bundle-generator + babel.
(timocov/dts-bundle-generator#347)

* chore(typescript): run prettier and fix lodash import

* chore(typescript): override autocorrect type in HTMLStencilElement for typescript 5.9 compatibility

Omit autocorrect from HTMLElement and redefine it as 'on' | 'off'.
Update node version to address breaking change with typed arrays in new typescript version.

* chore(typescript): improve type information for MockDocument location

Window.location's setter now takes a string, so update MockDocument.location's setter to match.

* chore(typescript): add TODO note to remove autocorrect override

Co-authored-by: John Jenkins <[email protected]>

* chore(typescript): update node types and typescript versions

Add ~ to typescript version to accept patch updates.
Update Node types version to match necessary version update in bundler test.

---------

Co-authored-by: John Jenkins <[email protected]>

Author: OS-jacobbell

package-lock.json

@@ -146,7 +146,7 @@
     "@types/graceful-fs": "^4.1.5",
     "@types/jest": "^27.0.3",
     "@types/listr": "^0.14.4",
-    "@types/node": "^20.12.11",
+    "@types/node": "^24.6.2",
     "@types/pixelmatch": "^5.2.4",
     "@types/pngjs": "^6.0.1",
     "@types/prompts": "^2.0.9",
@@ -197,19 +197,19 @@
     "semver": "^7.3.7",
     "terser": "5.37.0",
     "tsx": "^4.19.2",
-    "typescript": "~5.5.4",
+    "typescript": "~5.9.2",
     "webpack": "^5.75.0",
     "ws": "8.17.1"
   },
   "optionalDependencies": {
-    "@rollup/rollup-linux-x64-gnu": "4.34.9",
-    "@rollup/rollup-linux-x64-musl": "4.34.9",
-    "@rollup/rollup-linux-arm64-gnu": "4.34.9",
-    "@rollup/rollup-linux-arm64-musl": "4.34.9",
     "@rollup/rollup-darwin-arm64": "4.34.9",
     "@rollup/rollup-darwin-x64": "4.34.9",
-    "@rollup/rollup-win32-x64-msvc": "4.34.9",
-    "@rollup/rollup-win32-arm64-msvc": "4.34.9"
+    "@rollup/rollup-linux-arm64-gnu": "4.34.9",
+    "@rollup/rollup-linux-arm64-musl": "4.34.9",
+    "@rollup/rollup-linux-x64-gnu": "4.34.9",
+    "@rollup/rollup-linux-x64-musl": "4.34.9",
+    "@rollup/rollup-win32-arm64-msvc": "4.34.9",
+    "@rollup/rollup-win32-x64-msvc": "4.34.9"
   },
   "engines": {
     "node": ">=16.0.0",

package.json

@@ -55,11 +55,12 @@ export const isPrereleaseVersion = (version: string): boolean =>
  * @returns new version's string
  */
 export function getNewVersion(oldVersion: string, input: any): string {
-  if (!isValidVersionInput(input)) {
-    throw new Error(`Version should be either ${SEMVER_INCREMENTS.join(', ')} or a valid semver version.`);
-  }
+  const isValidSemverName = SEMVER_INCREMENTS.indexOf(input) === -1;
+  const incrementedSemverString = semver.inc(oldVersion, input);
 
-  return SEMVER_INCREMENTS.indexOf(input) === -1 ? input : semver.inc(oldVersion, input);
+  if (isValidSemverName) return input;
+  if (incrementedSemverString !== null) return incrementedSemverString;
+  throw new Error(`Version should be either ${SEMVER_INCREMENTS.join(', ')} or a valid semver version.`);
 }
 
 /**

scripts/utils/release-utils.ts

@@ -216,24 +216,26 @@ const getRealProperties = (properties: d.ComponentCompilerProperty[]): d.JsonDoc
  * @returns the derived metadata
  */
 const getVirtualProperties = (virtualProps: d.ComponentCompilerVirtualProperty[]): d.JsonDocsProp[] => {
-  return virtualProps.map((member) => ({
-    name: member.name,
-    type: member.type,
-    mutable: false,
-    attr: member.name,
-    reflectToAttr: false,
-    docs: member.docs,
-    docsTags: [],
-    default: undefined,
-    deprecation: undefined,
-    values: parseTypeIntoValues(member.type),
-
-    optional: true,
-    required: false,
-
-    getter: undefined,
-    setter: undefined,
-  }));
+  return virtualProps.map(
+    (member): d.JsonDocsProp => ({
+      name: member.name,
+      type: member.type,
+      mutable: false,
+      attr: member.name,
+      reflectToAttr: false,
+      docs: member.docs,
+      docsTags: [],
+      default: undefined,
+      deprecation: undefined,
+      values: parseTypeIntoValues(member.type),
+
+      optional: true,
+      required: false,
+
+      getter: undefined,
+      setter: undefined,
+    }),
+  );
 };
 
 const parseTypeIntoValues = (type: string): d.JsonDocsValue[] => {

src/compiler/docs/generate-doc-data.ts

@@ -1,4 +1,4 @@
-import { ComponentCompilerMeta } from '../../../declarations';
+import { ComponentCompilerMeta, ComponentCompilerMethod } from '../../../declarations';
 import { generateComponentTypes } from '../generate-component-types';
 import { stubComponentCompilerMeta } from './ComponentCompilerMeta.stub';
 import { stubComponentCompilerMethod } from './ComponentCompilerMethod.stub';
@@ -212,16 +212,18 @@ describe('generateComponentTypes', () => {
       const cmpMeta: ComponentCompilerMeta = {
         ...stubComponentCompilerMeta(),
         tagName: 'comprehensive-test',
-        methods: htmlElementMethods.slice(0, 5).map((methodName) => ({
-          ...stubComponentCompilerMethod(),
-          name: methodName,
-          complexType: {
-            signature: '() => Promise<void>',
-            parameters: [],
-            references: {},
-            return: 'Promise<void>',
-          },
-        })),
+        methods: htmlElementMethods.slice(0, 5).map(
+          (methodName): ComponentCompilerMethod => ({
+            ...stubComponentCompilerMethod(),
+            name: methodName,
+            complexType: {
+              signature: '() => Promise<void>',
+              parameters: [],
+              references: {},
+              return: 'Promise<void>',
+            },
+          }),
+        ),
       };
 
       const result = generateComponentTypes(cmpMeta, {}, false);

src/compiler/types/tests/generate-component-types.spec.ts

@@ -393,8 +393,10 @@ export declare function forceUpdate(ref: any): void;
  */
 export declare function getRenderingRef(): any;
 
-export interface HTMLStencilElement extends HTMLElement {
+export interface HTMLStencilElement extends Omit<HTMLElement, 'autocorrect'> {
   componentOnReady(): Promise<this>;
+  // TODO: remove this when [added to typescript](https://github.com/microsoft/typescript/issues/62083)
+  autocorrect: 'on' | 'off';
 }
 
 /**

src/declarations/stencil-public-runtime.ts

@@ -53,15 +53,15 @@ export class MockDocument extends MockHTMLElement {
     throw new Error('Unimplemented');
   }
 
-  get location() {
+  get location(): Location | null {
     if (this.defaultView != null) {
       return (this.defaultView as Window).location;
     }
     return null;
   }
-  set location(val: Location) {
+  set location(val: string) {
     if (this.defaultView != null) {
-      (this.defaultView as Window).location = val;
+      (this.defaultView as Window).location.href = val;
     }
   }
 

src/mock-doc/document.ts

@@ -167,7 +167,7 @@ function getParser(ownerDocument: MockDocument) {
     },
 
     getAttrList(element: MockElement) {
-      const attrs: Token.Attribute[] = element.attributes.__items.map((attr) => {
+      const attrs: Token.Attribute[] = element.attributes.__items.map((attr): Token.Attribute => {
         return {
           name: attr.name,
           value: attr.value,

src/mock-doc/parse-util.ts

@@ -1,4 +1,4 @@
-import * as path from 'path';
+const path = require('path');
 
 // we must use a relative path here instead of tsconfig#paths
 // see https://github.com/monounity/karma-typescript/issues/315