Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document macros for error codes corresponding to Modbus exceptions #758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Document macros for error codes corresponding to Modbus exceptions #758

wants to merge 2 commits into from

Conversation

kyllingstad
Copy link

This fixes #733.

@cla-bot cla-bot bot added the cla-signed label Jul 18, 2024
mhei
mhei reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mhei mhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to add the Modbus Exception Code as hex-number, too. This way, it is unambiguous clear which errno corresponds to which exception. For example:

- `EMBXILFUN`: illegal function (0x01)
- ...

@kyllingstad
Copy link
Author

Good suggestion. Done. (And sorry for the delayed response.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhei mhei mhei left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing documentation of errno values corresponding to Modbus exception codes
2 participants
@kyllingstad @mhei