DefinedTradeContact missing in Zugferd 2.1, EN16931/Comfort

[WernerK61]

Hi,

documentation for Zugferd 2.1 says that DefinedTradeContact is used in EN16931/Comfort.

If output profile XRechnung is used, then DefinedTradeContact is correctly written,
but if EN16931/Comfort is used, then DefinedTradeContact is omitted.

I guess that the reason is that in InvoiceDescriptor21Writer.cs Line 1185 Profile.Comfort is missing:
_writeOptionalContact(writer, "ram:DefinedTradeContact", contact, Profile.Extended | Profile.XRechnung1 | Profile.XRechnung);

Is this a bug, or is this DefinedTradeContact in EN16931 intentionally missing for some reason ?

Regards
Werner

[stephanstapel]

I see your point. Things are a bit more complicated unfortunately. Please search for DefinedTradeContact in the TA document.

DefinedTradeContact is written in Comfort profile only for the parties:

• SellerTradeParty
• BuyerTradeParty

but not:

• ShipToTradeParty
• UltimateShipToTradeParty
• ShipFromTradeParty
• InvoicerTradeParty (not yet implemented)
• PayeeTradeParty (not yet implemented)
• SellerTaxRepresentativeTradeParty (not yet implemented)
• ProductEndUserTradeParty (not yet implemented)

i.e. trade party is not trade party anymore. I honestly have no idea how to implement this as _writeOptionalParty() is used for all sorts of parties.

[KSafadi]

Same issue for me. When Profile basic is used, then DefinedTradeContact is omitted. When using XRECHNUNG, everything works.

[stephanstapel]

@KSafadi: yes, that should be alright. It is defined like this in the specification.
btw: which type of party are you writing to the invoice file? There are multiple scenarios, when DefinedTradeContact is written and when not

[KSafadi]

@stephanstapel alright! I am writing to the SellerTradeParty.

[stephanstapel]

In case of SellerTradeParty, it should be written only in these profiles:

[stephanstapel]

ZUGFeRD-csharp/ZUGFeRD/InvoiceDescriptor22Writer.cs

Line 1369 in 8c57c2e

_writeOptionalContact(writer, "ram:DefinedTradeContact", contact, Profile.Extended | Profile.XRechnung1 | Profile.XRechnung);

[KSafadi]

@stephanstapel ah okay that makes sense. Thank you.

[marvinvalent]

@stephanstapel I don't understand. Wouldn't that call of _writeOptionalContact need Profile.Comfort added to the Profile-parameter for it to be written in the profile for EN 16931?

[stephanstapel]

@marvinvalent : you are right, thanks