-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-Rechnung 3.1 UBL for Deutsche Bahn - writing taxes #261
Comments
sum up taxes, probably easier with LINQ |
Are you sure that grouping the taxes by category code is correct? |
Hi!
No I'm not sure, a bit confused, see
https://docs.peppol.eu/poacc/billing/3.0/syntax/ubl-invoice/cac-TaxTotal/cac-TaxSubtotal/
However, with my current output, the invoices are accepted by DB. Could be
shortsighted...
With the original code was not accepted... I'll try it again, later, a bit
busy today
Stephan ***@***.***> schrieb am Di., 14. Mai 2024, 21:04:
… Are you sure that grouping the taxes by category code is correct?
I guess that at least the percent need to be taken into account, otherwise
the result will be wrong.
And also, I thought the idea behind the taxes is that you can set
different exemption reasons and type codes for each tax.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYZBNOBYYCJ7TDUOOWAYCDZCJN4VAVCNFSM6AAAAABHJELPFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQHE2TCMRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
yep, good link! The text says: "Sum of all taxable amounts subject to a specific VAT category code and VAT category rate (if the VAT category rate is applicable)." I.e. this would be the taxes grouped by category and rate (percentage). This reflects the data structure of Peppol which only comes with these two categorizations: XRechnung comes with more detailed categorizations: i.e. I guess in this case, the grouping must happen by
|
Hi I post the current version (which in combination with the linetotalamoun change works). Don't forget #269...Without the changes in invoicedesriptor, thus providing the correct LineTotalAmount, it will not work.
#if DEBUG
|
The code above can't be correct. E.g. it wouldn't work with two VAT rates. |
Hi, I prototyped this having to output my actual invoices ... I will now verify with a standard test case (three different taxes, like a Hotel bill 19% 7% 0%) and verify the code. I was not sure if developing it furthermore was desired... so please give me some day... TIA! |
Yep. IThanks for your patience! Instead of
put
and it works. |
cool, that sounds more reasonable now. |
I took another look at the code. I now understand better that you add/reduce the tax that is given in the TradeAllowanceCharge from the global Tax (of same category, percentage etc.). |
Hi! Ich switch mal auf Deutsch, wird mir sonst zu mühsam... :-)
Hier könnte man - auf deine Frage hin - einen Fehler bei Abweichung der Eingabe zur Berechnung ausgeben- Insofern: wenn überhaupt, dann den Fehler auf Anwendungsebene managen und nicht erst nach gescheiterter Validierung... ist sicher Geschmacksache. |
broken down from #254, submitted by @goedo
InvoiceDescriptor22Writer.cs
The text was updated successfully, but these errors were encountered: