Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar button to show/hide child->parent relationship labels #22

Open
stevebuik opened this issue Jun 4, 2018 · 3 comments
Open

toolbar button to show/hide child->parent relationship labels #22

stevebuik opened this issue Jun 4, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stevebuik
Copy link
Owner

stevebuik commented Jun 4, 2018

is a render option called showEdgeSingularLabels. see TODO in graphviz.js

@stevebuik stevebuik added enhancement New feature or request help wanted Extra attention is needed labels Jun 4, 2018
@austinwang1121
Copy link
Collaborator

Let me take this one.

@austinwang1121 austinwang1121 self-assigned this Jun 10, 2018
@stevebuik
Copy link
Owner Author

Sure but a couple of things to note:

1/ Jason is in the middle of a big re-factor for Lightning/Apex so we need to leave that alone until he finishes or one of us will have a nasty merge
2/ I just finished a rebuild of the js code to generate from a new persistence shape so all new work should only be done in the new fns. you can see the new tests/code here https://github.com/stevebuik/Graphvizforce-Lightning/blob/master/js/pure/spec/GraphvizRenderSpec.js#L12

So this means you can do the js part of this issue right now but will need to wait for Jason to complete his work before it can be exposed to users. You can choose if you want to get a head start and do the js now (this will not interrupt Jason at all) or just wait for him to finish his two tasks.

@austinwang1121
Copy link
Collaborator

Hi Steve. I will wait for Jason to complete his tasks first. Cheers

@stevebuik stevebuik added the good first issue Good for newcomers label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants