Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading JPG images doesn't work and gives no errors #535

Open
the-viking opened this issue Jun 8, 2018 · 5 comments
Open

Uploading JPG images doesn't work and gives no errors #535

the-viking opened this issue Jun 8, 2018 · 5 comments

Comments

@the-viking
Copy link
Contributor

If jpegs aren't going work, there should be something in the documentation about how they don't work (and an error message)

@stevekrouse
Copy link
Owner

Wow, this is embarrassing. I have no clue why this is even broken

@truthgoddess
Copy link
Contributor

The issue isn't that .jpg don't work. The issue is that the images don't upload unless you are logged in and you have saved your project. A few times I tried to do this, the dialogue that showed up to say that you need to save to upload files didn't come up immediately.

For classes, we can just tell students to log in and save their work before trying to upload. I will try to figure out why that information doesn't come up right away in the near future.

@truthgoddess truthgoddess self-assigned this May 21, 2019
@stevekrouse
Copy link
Owner

Have you figured out why jpg uploads don't work? It may have to do how we set it up at the Firebase end... I need to give you and @madduccino access...

@truthgoddess
Copy link
Contributor

truthgoddess commented May 22, 2019

My guess is that it has something to do with the initiating process of uploading the images. That is, what has to be true for the upload process to work, or for the error that says, "You need to save" to work. I haven't put time into this yet, but will. All I did was confirm that we weren't having as big of an issue with this as we originally thought. I uploaded .jpg just fine after logging in and saving first and/or after doing it two times in a row. Therefore, we can pass on that solution to teachers.

@hallpell
Copy link
Collaborator

Still not clear to me what causes these issues. My insight from today was that a student reloaded create.html, and then was able to upload the same image successfully. The times I've been able to check, there hasn't been a error in the console. I suspect there might be an issue with raising errors based on my work on #609, but needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants