Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontawesome dependency coded on css file #151

Open
estreiten opened this issue Nov 23, 2016 · 2 comments
Open

Fontawesome dependency coded on css file #151

estreiten opened this issue Nov 23, 2016 · 2 comments

Comments

@estreiten
Copy link

By using ngWig in a project which has a Font Awesome library version newer than 4.4 as a dependency, the ngWig library downgrades that library to version 4.4.

On ng-wig.css file there's an import to Font Awesome library:
@import url("https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css");
It should be located on the bower.json file instead as a dependency, so we can manage version conflicts on our projects.

@estreiten estreiten changed the title Fontawesome dependency hardcoded on css Fontawesome dependency coded on css file Nov 23, 2016
@stevermeister
Copy link
Owner

yes, agree it's not good to have such a hardcode.
but nearest future probably we will skip bower as well (for npm).

@prismsoundzero
Copy link

I agree with @asadito such hardcoded dependency should be removed. We are using ng-wig in our project and this is causing a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants