remove manual cert validation for vorwerk connections #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofuSCHNITZEL
force-pushed
the
ssl_validation
branch
from
c6b5e38
to
c7fe4dc
Compare
|
this still might generate "Unverified HTTPS request is being made" warnings when used in home assistant... not sure why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the certificate for the vorwerk endpoint is not as long lived as the one for neatocloud (1y vs selfsigned until 2045)
I suggest removing the manual certificate validation in favour of the requests library built in cert validation.
cert_path is used directly as input for requests "verify" option so setting it to "True" should result in requests validating the cert with the systems certificate store.
this PR is the better alternative to #82 where we would need to monitor the vorkwerk endpoint cert and replace the cert and bump the version for this package every time