Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing PR title doesn't re-trigger the check #39

Open
polinalopit-tomtom opened this issue Jul 31, 2024 · 3 comments
Open

Editing PR title doesn't re-trigger the check #39

polinalopit-tomtom opened this issue Jul 31, 2024 · 3 comments

Comments

@polinalopit-tomtom
Copy link

image

I had one completed task in the PR description.
After adding another task to the description, I do see the task on the list, but the status is still "1/1 completed".

@stilliard
Copy link
Owner

That's pretty weird that it shows the 1/1 completed but then details showing a 2nd task.
I wonder if it's a visual glitch from github.
Could you give me an example PR body that replicates this please? Tested and updates seem to work for me but maybe something in the PR body is resulting in a bug our side.

@polinalopit-tomtom
Copy link
Author

I didn't notice anything special, there's even no special markup/formatting. Just plain text and a task list at the end.
I've changed some words in the description, as I can't provide the description as it. Here it is:

Introduction of breaking changes by accident or on purpose might slow down integration. To raise awareness and hopefully reduce the risk, this adds a check list item to the PR description.

  •  example to show how it affects the PR
  • task 2

@stilliard
Copy link
Owner

stilliard commented Aug 1, 2024

Hi @polinalopit-tomtom

I believe I've found that the issue is something in the character encoding of the - [ ] pasted.
The first one has an issue in it while the 2nd one doesn't, this causes the first to be ignored due to the encoding issue.

I'm not sure if github will auto fix this when I comment here but from my testing using your example:
This one breaks and is ignored: - [ ] 
While this one works: - [ ]
Switching in and out of using it on this test PR stilliard/test-repo-ignore#8

I suspect this is also the same issue as on #38 as maybe your 3rd task has the same encoding issue causing it to be ignored.

Could you try editing your PR on your project and re-type the - [ ] for each and see if that fixes it for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants