Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aria-expanded #5

Open
tmaier opened this issue Jan 1, 2022 · 3 comments · May be fixed by #11
Open

Support aria-expanded #5

tmaier opened this issue Jan 1, 2022 · 3 comments · May be fixed by #11

Comments

@tmaier
Copy link

tmaier commented Jan 1, 2022

I wonder how to enable proper accessibility/ARIA support for a navigation menu, which gets revealed with stimulus-reveal-controller.

This is an implementation reference: https://www.w3.org/TR/wai-aria-practices/examples/menu-button/menu-button-links.html
The challenge is aria-expanded="true" and aria-expanded="false" respectively, when the menu has been revealed or not.

Is there currently already a way to get this working?
@guillaumebriday
Copy link
Member

That would be nice!

Could you open a PR please 🙏

@guillaumebriday guillaumebriday linked a pull request Jun 1, 2023 that will close this issue
Open
@guillaumebriday
Copy link
Member

Hi @tmaier

Can you review this PR please #11?

@tmaier
Copy link
Author

tmaier commented Jun 19, 2023

Hi @guillaumebriday, I will try to do a test run within the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling aria-expanded state stimulus-components/stimulus-reveal-controller
2 participants
@tmaier @guillaumebriday