New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description string validation #104

Open

davidediger opened this issue Aug 3, 2015 · 0 comments

Collaborator

davidediger commented Aug 3, 2015

Each algorithm that registers with the server publishes a description string of its data storage array. There are a few unresolved issues here:

we don't actually validate the description string
we don't check that the "bytes per vertex" matches the description string
we don't check that the "bytes per vertex" is even positive
we don't check that the number of fields matches the number of data type identifiers
when we parse the description string, we don't stop after we have seen the right number of fields (as dictated by the data types)

These are fairly easy fixes, but they are spread around the JSON RPC server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment