Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adobe_source_libraries CMake build broken on multiple platforms #87

Open
ahmedjafri opened this issue Jan 22, 2022 · 1 comment
Open
Labels

Comments

@ahmedjafri
Copy link

ahmedjafri commented Jan 22, 2022

The CMake build is broken on multiple platforms for what seems to be several reasons.

Acceptance Criteria

  • A successful continuous integration using Github actions for the same windows, Mac, and Linux configurations that stlab/libraries supports

Note that #93 could be used as a start for continuous integration support.

Original Report

Here is my run of ./configure.sh and ./build.sh on MacOS 12.1

$ ./configure.sh
INFO : double-conversion found: skipping setup.
INFO : boost_libraries found: skipping setup.
INFO : No patchfile found for this version of Boost. Skipping.
INFO : b2 found: skipping boostrap.
...
INFO : You are ready to go!

$ ./build.sh
INFO : Make sure you run the configure script before this one to ensure dependencies are
in place.
ERRR : BUILDTOOL unknown. Goodbye.

./cmake_build_all.sh made some progress but then failed with a missing boost include

/Users/ajafri/code/adobe_source_libraries/../boost_libraries/libs/type_i
ndex/include/boost/type_index/type_index_facade.hpp:13:10: fatal error:
'boost/container_hash/hash_fwd.hpp' file not found
#include <boost/container_hash/hash_fwd.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[  7%] Building CXX object imported/double-conversion/CMakeFiles/double-
conversion.dir/double-conversion/fixed-dtoa.cc.o
1 error generated.
make[2]: *** [CMakeFiles/boost_unit_test.dir/Users/ajafri/code/boost_lib
raries/libs/test/src/debug.cpp.o] Error 1
make[1]: *** [CMakeFiles/boost_unit_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  7%] Building CXX object imported/double-conversion/CMakeFiles/double-
conversion.dir/double-conversion/string-to-double.cc.o
[  8%] Building CXX object imported/double-conversion/CMakeFiles/double-
conversion.dir/double-conversion/strtod.cc.o
In file included from /Users/ajafri/code/boost_libraries/libs/filesystem
/src/exception.cpp:15:
/Users/ajafri/code/adobe_source_libraries/../boost_libraries/libs/filesy
stem/include/boost/filesystem/path.hpp:33:10: fatal error: 'boost/functi
onal/hash_fwd.hpp' file not found
#include <boost/functional/hash_fwd.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/boost_glob.dir/Users/ajafri/code/boost_librarie
s/libs/filesystem/src/exception.cpp.o] Error 1
make[1]: *** [CMakeFiles/boost_glob.dir/all] Error 2
[  8%] Linking CXX static library libdouble-conversion.a
[  8%] Built target double-conversion
make: *** [all] Error 2
@camio
Copy link
Contributor

camio commented Jul 15, 2022

I can confirm that there are build issues here. I tried adding basic continuous integration support using CMake and encountered similar issues. See #93. I will advocate that we address this in the next sprint (starting some time next week).

@camio camio added the bug label Jul 15, 2022
@camio camio changed the title Build broken on Mac CMake build broken on multiple platforms Jul 15, 2022
@camio camio changed the title CMake build broken on multiple platforms adobe_source_libraries CMake build broken on multiple platforms Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants