-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow subHeaders to be a function, like unsubHeaders #298
Comments
Note, ultimately fixing stomp-js/stompjs#290 would be the cleanest solution here also, but in the meantime I think allowing a function value for the subHeader should be quick and easy...I will prep a PR if in agreement? |
vigie
added a commit
to vigie/rx-stomp
that referenced
this issue
Mar 12, 2021
This is the fix to issue stomp-js#298 Without this, a stale value can be passed through a header during an automatic resubscribe
vigie
added a commit
to vigie/rx-stomp
that referenced
this issue
Mar 12, 2021
This is the fix to issue stomp-js#298 Without this, a stale value can be passed through a header during an automatic resubscribe I am moving the version with this MR to 1.1.0 as this should be considered a non-breaking feature addition.
vigie
added a commit
to vigie/rx-stomp
that referenced
this issue
Mar 12, 2021
This is the fix to issue stomp-js#298 Without this, a stale value can be passed through a header during an automatic resubscribe I am moving the version with this MR to 1.1.0 as this should be considered a non-breaking feature addition.
vigie
added a commit
to vigie/rx-stomp
that referenced
this issue
Mar 13, 2021
This is the fix to issue stomp-js#298 Without this, a stale value can be passed through a header during an automatic resubscribe
kum-deepak
pushed a commit
that referenced
this issue
Mar 14, 2021
This is the fix to issue #298 Without this, a stale value can be passed through a header during an automatic resubscribe
Released as @stomp/rx-stomp 1.1.0 at npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Imagine you are using subHeaders to pass an
access-token
- a common use case.The problem comes in the context of automatic re-subscriptions after a disconnect.
WIthout allowing the value to be a function that can return the headers, during an automatic reconnect of the observable the client can end up sending an expired value for the token.
The text was updated successfully, but these errors were encountered: