Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stomp+SSL Url Strings in non-failover case. #158

Open
choilive opened this issue Jan 2, 2019 · 4 comments
Open

Support Stomp+SSL Url Strings in non-failover case. #158

choilive opened this issue Jan 2, 2019 · 4 comments

Comments

@choilive
Copy link

choilive commented Jan 2, 2019

It appears using a "stomp+ssl://..." URL string is unsupported. It falls through to the default case. (Attempts to connect to localhost:61613) however it appears +ssl is supported when specifying URL strings for a failover.

Any reason why we couldnt use the same regex that parses the failover host urls for the regular url parsing?

regexp = /^stomp:\/\/#{URL_REPAT}/

host_match = /stomp(\+ssl)?:\/\/#{URL_REPAT}/

@gmallard
Copy link

gmallard commented Jan 3, 2019

No reason that cannot be done I suppose.

Do you want to make the change and give me a PR?

@gmallard
Copy link

gmallard commented Jan 3, 2019

Actually the gem has never supported SSL really well except when using hashed login parameters.

I do not think this will work very well ..........

@choilive
Copy link
Author

choilive commented Jan 3, 2019

I'll try to implement it and if it works out will submit a PR.

@gmallard
Copy link

@choilive - any progress or thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants