Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: shasum vs sha1sum etc. #4

Open
brodycj opened this issue Dec 15, 2022 · 1 comment
Open

build: shasum vs sha1sum etc. #4

brodycj opened this issue Dec 15, 2022 · 1 comment

Comments

@brodycj
Copy link

brodycj commented Dec 15, 2022 •
edited
Loading

https://stackoverflow.com/questions/28490500/how-to-installing-sha1sum-in-mac-os

Makefile seems to want sha1sum but macOS has shasum. I think we should use an environmental variable for this.

P.S. It looks like upstream sql-js is now using both sha1sum & sha3sum
@brodycj
Copy link
Author

brodycj commented Dec 15, 2022 •
edited
Loading

NOW REVERTED: I just pushed d19fd9b with overridable SHA_SUM

to build on macOS, for example:

make dist/sql-asm-memory-growth.js SHA_SUM=shasum

I would like to get overridable setting SHASUM or SHA1SUM in upstream sql-js version.

P.S. Should probably revert this, they are now using both SHA-1 & SHA-3 checksums.

@brodycj brodycj changed the title build: shasum vs sha1sum build: shasum vs sha1sum etc. Dec 15, 2022
@brodycj brodycj mentioned this issue Dec 15, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brodycj