Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Icons & Badge [reference (Badged)PlatformTabbedPage] #4

Open
npagare opened this issue Aug 26, 2018 · 3 comments
Open

Supporting Icons & Badge [reference (Badged)PlatformTabbedPage] #4

npagare opened this issue Aug 26, 2018 · 3 comments

Comments

@npagare
Copy link

npagare commented Aug 26, 2018

Hi @stormlion227 , thank you for this great work.

Is there any possibility of supporting Icons and badges like the one provided by
https://www.nuget.org/packages/PlatformTabbedPage/2.2.0-beta and
https://www.nuget.org/packages/BadgedPlatformTabbedPage/0.4.0-badges

That will really make this Custom TabbedPage very very powerful .
Hope you will consider my feature request.

Thanks,

@npagare
Copy link
Author

npagare commented Aug 27, 2018

Hi @stormlion227,

I tried upgrading STabbedPage to the latest stable of Xamarin Forms 3.1.0.***** but couldn't get that compiled. It seems you have put some restrictions on Nuget packages related Android API 26.

I am not much familiar with coding of Xamarin Native to contribute effectively for this project. But, I am very much interested helping you to take this TabbedPage renderer to the next level. I can certainly contribute in writing test cases and testing. Let me know if you are interested.

In the mean time, please take a look at features provided by above two packages. I will really appreciate if can help me and the community to take it to the next highest level.

Thanks,

@stormlion227
Copy link
Owner

stormlion227 commented Aug 27, 2018

Hello

You can put icon and badge in TabBarCellTemplate freely.

		<!-- Cell Template -->
		<stab:STabbedPage.TabBarCellTemplate>
			<DataTemplate>
				<Grid BackgroundColor="White">
                                    <Image ... /> <!-- Icon -->
				</Grid>
			</DataTemplate>
		</stab:STabbedPage.TabBarCellTemplate>
		
		<!-- Selected Cell Template -->
		<stab:STabbedPage.TabBarSelectedCellTemplate>
			<DataTemplate>
				<Grid BackgroundColor="Orange">
                                       <Image .../> <!-- Selected Icon -->
				</Grid>
			</DataTemplate>
		</stab:STabbedPage.TabBarSelectedCellTemplate>

@npagare
Copy link
Author

npagare commented Aug 27, 2018

Hi @stormlion227 , thank you for your quick response.

Please see another issue #5 that I opened earlier too. I assumed the cell structure for icon and badge to be given in the same grid that is hosting the design for the TabItem. Is that not correct?


| Icon | Badge |
|------------------------------- |
| Tab Item Label /Text |

Also, upgrading of the Xamarin Form to 3.1.0.***** gives the following compilation error -
Severity Code Description Project File Line Suppression State
Warning This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ....\packages\Xamarin.Android.Support.Annotations.26.1.0.1\build\MonoAndroid80\Xamarin.Android.Support.Annotations.targets. STabbedPage.Android C:***\Dev\GitHub\STabbedPage.Forms\STabbedPage\STabbedPage.Android\STabbedPage.Android.csproj 164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants