Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Undeprecate knobs. #52

Open
mctrafik opened this issue Jul 7, 2023 · 2 comments
Open

[Request] Undeprecate knobs. #52

mctrafik opened this issue Jul 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mctrafik
Copy link

mctrafik commented Jul 7, 2023

Looks like the addon still works fine in version 7 and it's still a better offering than controls. Why don't you undeprecate it and start accepting incoming PRs again?

@mctrafik mctrafik added the bug Something isn't working label Jul 7, 2023
@literalpie
Copy link
Collaborator

The only reason the addon still works is because I (a community member) contributed fixes to maintain compatibility.
I would not take that as a sign that sticking with knobs forever is a good solution.

@mctrafik
Copy link
Author

@literalpie And thank you for that.

The background for this is that I tried contributing a couple of bugixes a couple years back and was told that no PRs are being accepted because the addon isn't supported. It's a shame to come back to this later to see some maintenance being performed and this still being the best option for toggles in storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants