Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offset to keyboard-focused outlines #272

Open
darleendenno opened this issue Jun 21, 2021 · 3 comments
Open

Add offset to keyboard-focused outlines #272

darleendenno opened this issue Jun 21, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@darleendenno
Copy link
Contributor

Description

The outline for keyboard-focused elements looks a little crowded. It was recommended in #271 to add an outline offset to improve visibility and streamline accessibility design.

image

Acceptance Criteria

  • All buttons that are keyboard-focused should have an outline offset
  • All links that are keyboard-focused should have an outline offset
@darleendenno darleendenno added the enhancement New feature or request label Jun 21, 2021
@domyen
Copy link
Member

domyen commented Jun 30, 2021

I believe this is merged now

@domyen domyen closed this as completed Jun 30, 2021
@darleendenno
Copy link
Contributor Author

darleendenno commented Jun 30, 2021 •
edited
Loading

@domyen I don’t think so. We recently merged #271 but didn’t address this issue because it was out of scope.

@darleendenno darleendenno reopened this Jul 6, 2021
@darleendenno
Copy link
Contributor Author

There is a concern that adding an offset could disrupt current layouts. I think we should take an inventory when CSF 3.0 is released and we can snapshot these interactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domyen @darleendenno