Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withStorybook.d.ts file is not emitted #646

Open
trajano opened this issue Nov 8, 2024 · 1 comment
Open

withStorybook.d.ts file is not emitted #646

trajano opened this issue Nov 8, 2024 · 1 comment

Comments

@trajano
Copy link
Contributor

trajano commented Nov 8, 2024

Describe the bug
#633 switches to typescript which is good, but the code needs a change to get the typings correct in the .d.ts

As I noted in the comment @tlow92 you added the hack I did for .d.ts to export it as a function but it does not send the correct typing and the .d.ts emitted is actually not correct. So I had to patch it back to

export = withStorybook;

I think all you need to do as I had commented is is export function withStorybook and it will emit the .d.ts correctly.

@dannyhw
Copy link
Member

dannyhw commented Nov 8, 2024

eek, thats weird I didn't notice that

trajano added a commit to trajano/expo-experiments that referenced this issue Nov 9, 2024
Still unable to determine what's causing storybookjs/react-native#646

The typings look correct in the code but the emit didn't render something that works across

- tsc
- WebStorm
- VS Code
- expo export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants