diff --git a/.circleci/config.yml b/.circleci/config.yml index 28e37540c110..2273bcc5bdf3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -341,30 +341,6 @@ jobs: paths: - sandbox/*/bench/*.json - sandbox/*/storybook-static - build-test-sandboxes: - parameters: - parallelism: - type: integer - executor: - class: large - name: sb_node_16_browsers - parallelism: << parameters.parallelism >> - steps: - - git-shallow-clone/checkout_advanced: - clone_options: '--depth 1 --verbose' - - attach_workspace: - at: . - - run: - name: Building Sandboxes - command: yarn task --task test-build --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build) --no-link --start-from=never --junit - - report-workflow-on-failure: - template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build) - - store_test_results: - path: test-results - - persist_to_workspace: - root: . - paths: - - sandbox/*/bench/test-build.json test-runner-production: parameters: parallelism: @@ -526,10 +502,6 @@ workflows: parallelism: 12 requires: - build - - build-test-sandboxes: - parallelism: 12 - requires: - - create-sandboxes - build-sandboxes: parallelism: 12 requires: @@ -554,7 +526,6 @@ workflows: parallelism: 3 requires: - build-sandboxes - - build-test-sandboxes # TODO: reenable once we find out the source of flakyness # - test-runner-dev: # requires: @@ -587,10 +558,6 @@ workflows: parallelism: 21 requires: - build - - build-test-sandboxes: - parallelism: 12 - requires: - - create-sandboxes - build-sandboxes: parallelism: 21 requires: @@ -615,7 +582,6 @@ workflows: parallelism: 3 requires: - build-sandboxes - - build-test-sandboxes # TODO: reenable once we find out the source of flakyness # - test-runner-dev: # parallelism: 4 @@ -649,10 +615,6 @@ workflows: # - smoke-test-sandboxes: # disabled for now # requires: # - create-sandboxes - - build-test-sandboxes: - parallelism: 12 - requires: - - create-sandboxes - build-sandboxes: parallelism: 36 requires: @@ -678,4 +640,3 @@ workflows: # parallelism: 4 # requires: # - create-sandboxes - diff --git a/code/frameworks/angular/src/builders/build-storybook/index.ts b/code/frameworks/angular/src/builders/build-storybook/index.ts index 114f626e57f6..9bbd4b53c3e1 100644 --- a/code/frameworks/angular/src/builders/build-storybook/index.ts +++ b/code/frameworks/angular/src/builders/build-storybook/index.ts @@ -33,7 +33,6 @@ addToGlobalContext('cliVersion', versions.storybook); export type StorybookBuilderOptions = JsonObject & { browserTarget?: string | null; tsConfig?: string; - test: boolean; docs: boolean; compodoc: boolean; compodocArgs: string[]; diff --git a/code/frameworks/angular/src/builders/build-storybook/schema.json b/code/frameworks/angular/src/builders/build-storybook/schema.json index 6b614e574172..594038eeecca 100644 --- a/code/frameworks/angular/src/builders/build-storybook/schema.json +++ b/code/frameworks/angular/src/builders/build-storybook/schema.json @@ -49,11 +49,6 @@ "description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation.", "default": false }, - "test": { - "type": "boolean", - "description": "Build the static version of the sandbox optimized for testing purposes", - "default": false - }, "compodoc": { "type": "boolean", "description": "Execute compodoc before.", diff --git a/code/lib/cli/src/generate.ts b/code/lib/cli/src/generate.ts index 76c00eca2d2a..fa52682ee278 100644 --- a/code/lib/cli/src/generate.ts +++ b/code/lib/cli/src/generate.ts @@ -259,7 +259,6 @@ command('build') ) .option('--force-build-preview', 'Build the preview iframe even if you are using --preview-url') .option('--docs', 'Build a documentation-only site using addon-docs') - .option('--test', 'Build stories optimized for testing purposes.') .action(async (options) => { process.env.NODE_ENV = process.env.NODE_ENV || 'production'; logger.setLevel(program.loglevel); diff --git a/scripts/bench/bench.schema b/scripts/bench/bench.schema index bdee2f02fd56..d459223136a0 100644 --- a/scripts/bench/bench.schema +++ b/scripts/bench/bench.schema @@ -18,15 +18,6 @@ buildSbPreviewSize: INTEGER, buildStaticSize: INTEGER, buildPrebuildSize: INTEGER, buildPreviewSize: INTEGER, -testBuildTime: INTEGER, -testBuildSize: INTEGER, -testBuildSbAddonsSize: INTEGER, -testBuildSbCommonSize: INTEGER, -testBuildSbManagerSize: INTEGER, -testBuildSbPreviewSize: INTEGER, -testBuildStaticSize: INTEGER, -testBuildPrebuildSize: INTEGER, -testBuildPreviewSize: INTEGER, devPreviewResponsive: INTEGER, devManagerResponsive: INTEGER, devManagerHeaderVisible: INTEGER, diff --git a/scripts/bench/types.ts b/scripts/bench/types.ts index 0d86755ff8e5..da00af720ad2 100644 --- a/scripts/bench/types.ts +++ b/scripts/bench/types.ts @@ -38,24 +38,6 @@ export interface BenchResults { buildPrebuildSize: number; /** Total size of everything else (user's stories & components & CSS & assets etc.) */ buildPreviewSize: number; - /** Full `sb build` time */ - testBuildTime: number; - /** Size of the storybook-static directory in total */ - testBuildSize: number; - /** Size of the storybook-static/sb-addons in total */ - testBuildSbAddonsSize: number; - /** Size of the storybook-static/sb-common-assets */ - testBuildSbCommonSize: number; - /** Size of the storybook-static/sb-manager */ - testBuildSbManagerSize: number; - /** Size of storybook-static/sb-preview */ - testBuildSbPreviewSize: number; - /** Size of the `static` directory if it exists */ - testBuildStaticSize: number; - /** Total size of `sb-x` above */ - testBuildPrebuildSize: number; - /** Total size of everything else (user's stories & components & CSS & assets etc.) */ - testBuildPreviewSize: number; /** Time to wait-on iframe.html */ devPreviewResponsive: number; /** Time to wait-on index.html */ diff --git a/scripts/task.ts b/scripts/task.ts index 6cf4fa7e9993..897957653413 100644 --- a/scripts/task.ts +++ b/scripts/task.ts @@ -20,7 +20,7 @@ import { sandbox } from './tasks/sandbox'; import { syncDocs } from './tasks/sync-docs'; import { dev } from './tasks/dev'; import { smokeTest } from './tasks/smoke-test'; -import { build, testBuild } from './tasks/build'; +import { build } from './tasks/build'; import { serve } from './tasks/serve'; import { testRunnerBuild } from './tasks/test-runner-build'; import { testRunnerDev } from './tasks/test-runner-dev'; @@ -103,7 +103,6 @@ export const tasks = { dev, 'smoke-test': smokeTest, build, - 'test-build': testBuild, serve, 'test-runner': testRunnerBuild, 'test-runner-dev': testRunnerDev, diff --git a/scripts/tasks/build.ts b/scripts/tasks/build.ts index 09324edac58d..38aadb15fda6 100644 --- a/scripts/tasks/build.ts +++ b/scripts/tasks/build.ts @@ -48,49 +48,3 @@ export const build: Task = { ); }, }; - -export const testBuild: Task = { - description: 'Build the static version of the sandbox optimized for testing purposes', - dependsOn: ['sandbox'], - async ready({ builtSandboxDir }) { - return pathExists(builtSandboxDir); - }, - async run({ sandboxDir }, { dryRun, debug }) { - const start = now(); - - await exec(`yarn build-storybook --test --quiet`, { cwd: sandboxDir }, { dryRun, debug }); - - const testBuildTime = now() - start; - const dir = join(sandboxDir, 'storybook-static'); - const getSize = promisify(dirSize); - const testBuildSize = await getSize(dir); - const testBuildSbAddonsSize = await getSize(join(dir, 'sb-addons')); - const testBuildSbCommonSize = await getSize(join(dir, 'sb-common-assets')); - const testBuildSbManagerSize = await getSize(join(dir, 'sb-manager')); - const testBuildSbPreviewSize = await getSize(join(dir, 'sb-preview')); - const testBuildPrebuildSize = - testBuildSbAddonsSize + - testBuildSbCommonSize + - testBuildSbManagerSize + - testBuildSbPreviewSize; - - const testBuildStaticSize = await getSize(join(dir, 'static')).catch(() => 0); - const testBuildPreviewSize = testBuildSize - testBuildPrebuildSize - testBuildStaticSize; - - await saveBench( - 'test-build', - { - testBuildTime, - testBuildSize, - testBuildSbAddonsSize, - testBuildSbCommonSize, - testBuildSbManagerSize, - testBuildSbPreviewSize, - testBuildStaticSize, - testBuildPrebuildSize, - testBuildPreviewSize, - }, - { rootDir: sandboxDir } - ); - }, -}; diff --git a/scripts/upload-bench.ts b/scripts/upload-bench.ts index e841ec363c33..1b0d570ee821 100644 --- a/scripts/upload-bench.ts +++ b/scripts/upload-bench.ts @@ -34,15 +34,6 @@ const defaults: Record = { buildStaticSize: null, buildPrebuildSize: null, buildPreviewSize: null, - testBuildTime: null, - testBuildSize: null, - testBuildSbAddonsSize: null, - testBuildSbCommonSize: null, - testBuildSbManagerSize: null, - testBuildSbPreviewSize: null, - testBuildStaticSize: null, - testBuildPrebuildSize: null, - testBuildPreviewSize: null, devPreviewResponsive: null, devManagerResponsive: null, devManagerHeaderVisible: null,