From f3959332f2e2adddcb9354bd2f5bb8add5c564ee Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Mon, 18 Sep 2023 10:38:44 +0200 Subject: [PATCH] Merge pull request #24160 from pure-js/docs-add-pnpm-option-to-vite-build-page Closes https://github.com/chromaui/addon-visual-tests/pull/110#discussion_r1328223253 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## What I did - I changed the type-interface of `experimental_updateStatus` so it allows `null` as a value to indicate it should delete the status on a story. The runtime code was already correct. We didn't catch this because `manager-api` is still `strict:false` in `tsconfig.json`. ## Checklist for Contributors ### Testing #### The changes in this PR are covered in the following automated tests: - [ ] stories - [ ] unit tests - [ ] integration tests - [ ] end-to-end tests #### Manual testing I tested this manually, by changing `strict:false` to `true` and checking if it does not produce an error for that line. TS does produce an error, when I removed the `| null`, so I think that means this change is correct. ### Documentation - [ ] Add or update documentation reflecting your changes - [ ] If you are deprecating/removing a feature, make sure to update [MIGRATION.MD](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md) ## Checklist for Maintainers - [ ] When this PR is ready for testing, make sure to add `ci:normal`, `ci:merged` or `ci:daily` GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in `code/lib/cli/src/sandbox-templates.ts` - [ ] Make sure this PR contains **one** of the labels below:
Available labels - `bug`: Internal changes that fixes incorrect behavior. - `maintenance`: User-facing maintenance tasks. - `dependencies`: Upgrading (sometimes downgrading) dependencies. - `build`: Internal-facing build tooling & test updates. Will not show up in release changelog. - `cleanup`: Minor cleanup style change. Will not show up in release changelog. - `documentation`: Documentation **only** changes. Will not show up in release changelog. - `feature request`: Introducing a new feature. - `BREAKING CHANGE`: Changes that break compatibility in some way with current major version. - `other`: Changes that don't fit in the above categories.
### 🦋 Canary release This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the `@storybookjs/core` team here. _core team members can create a canary release [here](https://github.com/storybookjs/storybook/actions/workflows/canary-release-pr.yml) or locally with `gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=`_ --- code/lib/types/src/modules/api-stories.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/lib/types/src/modules/api-stories.ts b/code/lib/types/src/modules/api-stories.ts index 45acc19e35c7..b6c150242a2a 100644 --- a/code/lib/types/src/modules/api-stories.ts +++ b/code/lib/types/src/modules/api-stories.ts @@ -183,7 +183,7 @@ export interface API_StatusObject { } export type API_StatusState = Record>; -export type API_StatusUpdate = Record; +export type API_StatusUpdate = Record; export type API_FilterFunction = ( item: API_PreparedIndexEntry & { status: Record }