-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Addon Controls Issue with CSF and MDX format in Angular 7 #11452
Comments
Hi @shilman, Sorry for updating the content of the bug multiple times. I wanted t cover all the issues together. Please have a look at them. I have also added a gif that can give you more insights on the issue. Hope this would help your team :) One more question, I am starting to use Storybook hence want to understand that as part of the future releases which story format we should adopt CSF, StoriesOf API, or MDX. What is the recommendation? I don't want to end up using a format that might be deprecated in the coming months. Please let me know, thanks :) Regards, |
@akhilesh85 Thanks for the issue, I will take a look in the next few days. Re: formats, you should use either CSF or MDX. CSF is the "safest" one because it's core. MDX compiles to CSF internally, and should be getting v2 improvements soon and we will support that for documentation-rich scenarios. |
Hi @shilman , Thank you for your inputs. May I know when would be args and argTypes available in the Angular MDX version? If it is already there could you please provide a reference code snippet for the same. Thanks. Regards, |
Here's an MDX example for Vue. it should be straightforward to adapt the example to angular: https://raw.githubusercontent.com/storybookjs/storybook/next/examples/vue-kitchen-sink/src/stories/addon-controls.stories.mdx |
Sure, let me try it tomorrow. Thanks. |
Hi @shilman Thank you fr the reference the approach worked for angular. Thanks. But the Issues associated with MDX and CSF with docs addon still exists.
Please refer to the screenshot and the MDX Angular version code snippet. Code Snippet 1-Button.stories.mdx.txt Screenshot Environment Info System: (The behaviour is the same on Mac OS as well) |
Closing as duplicate to #11908 |
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
CSF Format
CSF Format Props appears only for the main story
MDX Format
Code snippets
Please find all the files attached. These are the files that are auto-generated by the storybook. I just amended to add more configuration to test the scenarios.
1-Button.stories.mdx.txt
1-Button.stories.ts.txt
button.component.ts.txt
documentation.json.txt
System:
Tried in below OS under different versions of Angular.
Mac OSX (Angular 7.0.2)
"@storybook/addon-controls": "^6.0.0-beta.44",
"@storybook/addon-docs": "^6.0.0-beta.44",
"@storybook/addon-actions": "^6.0.0-beta.44",
"@storybook/addon-links": "^6.0.0-beta.44",
"@storybook/angular": "^6.0.0-beta.44",
"@compodoc/compodoc": "^1.1.8",
Windows (Angular 9.0.7)
"@compodoc/compodoc": "^1.1.11",
"@storybook/addon-controls": "^6.0.0-beta.45",
"@storybook/addon-docs": "^6.0.0-beta.45",
"@storybook/addon-actions": "^6.0.0-beta.45",
"@storybook/addon-links": "^6.0.0-beta.45",
"@storybook/angular": "^6.0.0-beta.45",
The text was updated successfully, but these errors were encountered: