Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate storybook old repos #1850

Closed
danielduan opened this issue Sep 15, 2017 · 4 comments
Closed

Deprecate storybook old repos #1850

danielduan opened this issue Sep 15, 2017 · 4 comments
Assignees
Labels
cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks

Comments

@danielduan
Copy link
Member

danielduan commented Sep 15, 2017

I think these old repos should be moved to storybook-eol:

We can have a discussion on whether react-cdk should be deprecated as well:

I don't think users lose much by going to cra + storybook instead of react-cdk. We can migrate some of the code into our CLI so it generates some boilerplates as well if desired.

@danielduan danielduan added the maintenance User-facing maintenance tasks label Sep 15, 2017
@ndelangen
Copy link
Member

I've added you as an owner to the storybook-eol organisation! 👍

@danielduan danielduan self-assigned this Sep 15, 2017
@danielduan
Copy link
Member Author

danielduan commented Sep 15, 2017

alright, I'll move them.

@ndelangen looks like I don't have owner permission to storybook to transfer them out.

@danielduan danielduan added the cleanup Minor cleanup style change that won't show up in release changelog label Sep 15, 2017
@usulpro
Copy link
Member

usulpro commented Sep 15, 2017

I'd offer to not move react-cdk untill we can provide any better solution instead.

As for me react-cdk = empty folder + getstorybook

@danielduan
Copy link
Member Author

danielduan commented Sep 15, 2017

@usulpro would you feel comfortable putting a DEPRECATED label on the repo and the readme? I feel like it's misleading to users if we're not going to provide ongoing support for it.

For reference to others: storybook-eol/react-cdk#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants