Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of text and icon on sidebar is changed when font of storybook is changed #18607

Closed
saravanamani1999 opened this issue Jun 30, 2022 · 8 comments · Fixed by #22221
Closed
Assignees
Labels

Comments

@saravanamani1999
Copy link

Have changed the font to open sans in theme.js and when doing so, the alignment of the text to the icons on the sidebar gets affected as shown in the image

alignment_off_center

@ndelangen
Copy link
Member

@saravanamani1999 is this still an issue in 7.0 beta?

If you would you be interested in opening a PR to address this?

@iamkelv
Copy link

iamkelv commented Jan 25, 2023

@ndelangen is the issue still open? I will like to work on it

@ndelangen
Copy link
Member

It might be @iamkelv ! I'm not sure.

If you'd do an investigation, create a reproduction? 🙏

@himanshu1221
Copy link

Can I work on this issue?

@ndelangen
Copy link
Member

@himanshu1221 yea please! That would be very welcome indeed!

@ParbhatKataria1
Copy link

Is this issue resolved? If not, I would love to fix it.

@ndelangen
Copy link
Member

@ParbhatKataria1 I'm not sure, I just updated this PR: #22221

Would you be interested in reviewing it and testing it for yourself?

@github-actions
Copy link
Contributor

Hi there! Thank you for opening this issue, but it has been marked as stale because we need more information to move forward. Could you please provide us with the requested reproduction or additional information that could help us better understand the problem? We'd love to resolve this issue, but we can't do it without your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants