Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docs filter logic of mount stories to the Stories block #28420

Closed
kasperpeulen opened this issue Jul 2, 2024 · 0 comments · Fixed by #28434
Closed

Move docs filter logic of mount stories to the Stories block #28420

kasperpeulen opened this issue Jul 2, 2024 · 0 comments · Fixed by #28434
Assignees

Comments

@kasperpeulen
Copy link
Contributor

Move the filtering here:

if (mountUsed) {
// Don't show stories where mount is used in docs.
// As the play function is not running in docs, and when mount is used, the mounting is happening in play itself.
tags = tags.filter((tag) => tag !== 'autodocs');
}

To this line:

stories = stories.filter((story) => story.tags?.includes('autodocs'));

And revisit with @shilman if we can make it more obvious for users that those stories are filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant