Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect royaltyVaultIpId naming #375

Open
jacob-tucker opened this issue Jan 2, 2025 · 1 comment
Open

Incorrect royaltyVaultIpId naming #375

jacob-tucker opened this issue Jan 2, 2025 · 1 comment

Comments

@jacob-tucker
Copy link
Contributor

In src/resources/royalty.ts, there are many functions that have a parameter named royaltyVaultIpId. These should actually be renamed to ipId. The expected parameter is not the royalty vault id, rather it is the ip id of the asset associated with the royalty vault.

For example, here is snapshotAndClaimByTokenBatch
Screenshot 2025-01-01 at 9 45 27 PM

However in the actual contract, it is called ipId
image

I think it is confusing, and making it ipId would be more clear for developers
@jacob-tucker
Copy link
Contributor Author

Also adding that we got this feedback from developers in Discord:

Screenshot 2025-01-01 at 9 46 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacob-tucker