Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CacheController): Data race in test #321

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

DavidNix
Copy link
Contributor

@DavidNix DavidNix commented Jul 6, 2023

Closes #320

The data race was inherent only to the tests.

I'm not sure why I was testing that last use case (may have been a mistake). We test zero state in another subtest which should cover our bases there.

Stress test results:

❯ go test -race -c ./internal/cosmos && stress ./cosmos.test
5s: 733 runs so far, 0 failures
10s: 1515 runs so far, 0 failures
15s: 2293 runs so far, 0 failures
20s: 3065 runs so far, 0 failures
25s: 3814 runs so far, 0 failures
30s: 4583 runs so far, 0 failures
35s: 5356 runs so far, 0 failures
40s: 6101 runs so far, 0 failures
45s: 6861 runs so far, 0 failures
50s: 7640 runs so far, 0 failures
55s: 8375 runs so far, 0 failures
1m0s: 9108 runs so far, 0 failures
1m5s: 9851 runs so far, 0 failures
1m10s: 10606 runs so far, 0 failures
1m15s: 11354 runs so far, 0 failures
1m20s: 12110 runs so far, 0 failures
1m25s: 12869 runs so far, 0 failures
1m30s: 13626 runs so far, 0 failures
1m35s: 14366 runs so far, 0 failures
1m40s: 15115 runs so far, 0 failures
1m45s: 15874 runs so far, 0 failures
1m50s: 16640 runs so far, 0 failures
1m55s: 17404 runs so far, 0 failures
2m0s: 18143 runs so far, 0 failures
2m5s: 18855 runs so far, 0 failures
2m10s: 19607 runs so far, 0 failures
2m15s: 20364 runs so far, 0 failures
2m20s: 21137 runs so far, 0 failures
2m25s: 21901 runs so far, 0 failures
2m30s: 22661 runs so far, 0 failures
2m35s: 23422 runs so far, 0 failures
2m40s: 24159 runs so far, 0 failures
2m45s: 24916 runs so far, 0 failures
2m50s: 25649 runs so far, 0 failures
2m55s: 26386 runs so far, 0 failures
3m0s: 27142 runs so far, 0 failures
3m5s: 27871 runs so far, 0 failures
3m10s: 28633 runs so far, 0 failures
3m15s: 29399 runs so far, 0 failures
3m20s: 30159 runs so far, 0 failures

@DavidNix DavidNix requested a review from danbryan July 6, 2023 15:51
@DavidNix DavidNix marked this pull request as ready for review July 6, 2023 15:52
@DavidNix DavidNix merged commit 8eb17fe into main Jul 6, 2023
2 checks passed
@DavidNix DavidNix deleted the nix/fix/cache-controller-data-race branch July 6, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in CacheController
2 participants