From 78418f66c4d74f59e5cf8dd525f1b5693c2c1070 Mon Sep 17 00:00:00 2001 From: Reece Williams Date: Fri, 20 Sep 2024 10:10:54 -0500 Subject: [PATCH] reduce test flakiness by only verifying with rly --- examples/ibc/ics_test.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/examples/ibc/ics_test.go b/examples/ibc/ics_test.go index 9ba5d089a..14caa0f47 100644 --- a/examples/ibc/ics_test.go +++ b/examples/ibc/ics_test.go @@ -3,6 +3,7 @@ package ibc_test import ( "context" "fmt" + "os" "strings" "testing" @@ -32,12 +33,17 @@ func TestICS(t *testing.T) { icsVersions = []string{ver} } - relayers := []struct { + type relayerTypes struct { rly ibc.RelayerImplementation name string - }{ - {rly: ibc.Hermes, name: "hermes"}, - {rly: ibc.CosmosRly, name: "rly"}, + } + relayers := []relayerTypes{{rly: ibc.CosmosRly, name: "rly"}} + + // t / true + if strings.HasPrefix(os.Getenv("ICT_WITH_HERMES"), "t") { + // reduces test flakeyness in CI, no need to verify with Hermes + // we just need to confirm the ICS works as expected with respect to migrations. + relayers = append(relayers, relayerTypes{rly: ibc.Hermes, name: "hermes"}) } for _, version := range icsVersions {