Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICT should give more descriptive errors when chain genesis validation fails #1238

Closed
dowlandaiello opened this issue Aug 30, 2024 · 2 comments · Fixed by #1258
Closed

ICT should give more descriptive errors when chain genesis validation fails #1238

dowlandaiello opened this issue Aug 30, 2024 · 2 comments · Fixed by #1258
Assignees
Labels
UX User Experience Improvements

Comments

@dowlandaiello
Copy link

It would be helpful if local-ic was able to report more detailed errors when, for example, a parameter in the chain genesis JSON is incorrectly spelled or misplaced. Currently, this results in a bizarre, ambiguous error unrelated to the genesis at all, and the only way to determine the source of the error is by looking through the killed docker container's logs.

Example incorrect chain genesis param:

{
          "key": "app_state.gov.params.deposit_period",
          "value": "3s
},

Example current error:

2024-08-30T17:03:43.787Z        FATAL   interchain/start.go:176 ic.Build        {"error": "failed to start chains: failed to start chain localosmosis-1: All attempts fail:\n#1: post failed: Post \"http://0.0.0.0:26659\": dial tcp 0.0.0.0:26659: connect: connection refused\n#2: post failed: Post \"http://0.0.0.0:26659\": dial tcp 0.0.0.0:26659: connect: connection refused\n#3: post failed: Post \"http://0.0.0.0:26659\": dial tcp 0.0.0.0:26659: connect: connection refused\n#4: post failed: Post \"http://0.0.0.0:26659\": dial tcp 0.0.0.0:26659: connect: connection refused\n#5: post failed: Post \"http://0.0.0.0:26659\": dial tcp 0.0.0.0:26659: connect: connection refused\n#6: post failed: Post \"http://0.0.0.0:26659\": ..................

This is not necessarily a bug or anything, but it would be nice if the error from inside the docker container could be bubbled up to local-ic somehow!

@Reecepbcups
Copy link
Member

Reecepbcups commented Sep 16, 2024

Agree!

Currently Interchaintest does not read / parse panics in a proper way to show the user. I had an issue on this, unsure where it went. Once a panic parser is in ICT this will be automatically added to local-ic as well due to how it is designed.

Also ref:

@Reecepbcups Reecepbcups self-assigned this Sep 16, 2024
@Reecepbcups Reecepbcups added the UX User Experience Improvements label Sep 16, 2024
@Reecepbcups
Copy link
Member

PR is up and pending review from our side. It will parse out any panics on startup, return this error, show all the logs, and cleanup any containers hanging.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User Experience Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants