Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only chainConfig should have the ability to pass GasAdjustment (ie, chainSpec should not) #497

Closed
boojamya opened this issue Apr 13, 2023 · 0 comments · Fixed by #717
Closed

only chainConfig should have the ability to pass GasAdjustment (ie, chainSpec should not) #497

boojamya opened this issue Apr 13, 2023 · 0 comments · Fixed by #717

Comments

@boojamya
Copy link
Contributor

boojamya commented Apr 13, 2023 •
edited by jonathanpberger
Loading

GasAdjustment is in both chainSpec and chainConfig which can be confusing

Issue brought up here: #482

We should remove the ability to pass GasAdjustment in the chainSpec and only use the value in the chainConfig
@boojamya boojamya mentioned this issue Apr 13, 2023
Closed
@jonathanpberger jonathanpberger changed the title GasAdjustment is in both chainSpec and chainConfig which can be confusing only chainConfig should have the ability to pass GasAdjustment (ie, chainSpec should not) Apr 24, 2023
@Reecepbcups Reecepbcups mentioned this issue Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove GasAdjustment override from ChainSpec strangelove-ventures/interchaintest
1 participant
@boojamya