Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v7) make functions and packages public #869

Closed
2 tasks done
Reecepbcups opened this issue Nov 9, 2023 · 2 comments · Fixed by #1038
Closed
2 tasks done

(v7) make functions and packages public #869

Reecepbcups opened this issue Nov 9, 2023 · 2 comments · Fixed by #1038

Comments

@Reecepbcups
Copy link
Member

Reecepbcups commented Nov 9, 2023

Since this is a framework for testing, we should attempt to make all functions (within reason) public.

Versions

  • v7

  • v8 (main)

  • ex: PrivValFileContent and OverwritePrivValFile in v7.

this may also be useful with the internal/ repo. For example, the local-interchain lense clone could use docker internal functions, but it can not be accessed outside.

@chatton
Copy link
Contributor

chatton commented Mar 14, 2024

Was just going to create an issue to make some of the functions in the internal package public, specifically the FileRetriever type and associated functions, fetching files (such as private keys) from validator nodes can be extremely useful in some more complex test scenarios.

@Reecepbcups Reecepbcups pinned this issue Mar 14, 2024
@Reecepbcups Reecepbcups reopened this Apr 9, 2024
@Reecepbcups Reecepbcups changed the title make functions and packages public (v7) make functions and packages public Apr 9, 2024
@Reecepbcups Reecepbcups unpinned this issue Apr 28, 2024
@Reecepbcups
Copy link
Member Author

Compelted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants