Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local-ic cors #1226

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: local-ic cors #1226

merged 1 commit into from
Aug 22, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Aug 21, 2024

Summary

Allows any origin for localhost to interact with the local-ic instance

Issue encountered by @marslavish

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Aug 21, 2024 7:31pm

@Reecepbcups
Copy link
Member Author

image
tested locally

@Reecepbcups Reecepbcups marked this pull request as ready for review August 21, 2024 19:40
@Reecepbcups Reecepbcups requested a review from a team as a code owner August 21, 2024 19:40
Copy link

@joelsmith-2019 joelsmith-2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reecepbcups
Copy link
Member Author

will merge after confirmation from the Cosmology team

@Reecepbcups
Copy link
Member Author

Confirmed to work for their team

@Reecepbcups Reecepbcups merged commit c3e1187 into main Aug 22, 2024
22 checks passed
@Reecepbcups Reecepbcups deleted the reece/fix-local-ic-cores branch August 22, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants