feat(geth): add ethereum support for the geth binary #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x utxo send amount
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…d it should be more stable.
Reecepbcups
reviewed
Aug 24, 2024
Comment on lines
+161
to
+167
| switch cfg.Bin { | ||
| case "anvil": | ||
| return foundry.NewAnvilChain(testName, cfg, log), nil | ||
| case "geth": | ||
| return geth.NewGethChain(testName, cfg, log), nil | ||
| default: | ||
| return nil, fmt.Errorf("unknown binary: %s for ethereum chain type, must be anvil or geth", cfg.Bin) |
There was a problem hiding this comment.
very nice, I like this design pattern a lot for this. clean & great UX
| @@ -36,7 +37,7 @@ func TestEthereum(t *testing.T) { | |||
| ctx := context.Background() | |||
|
|
|||
| // Get default ethereum chain config for anvil | |||
| anvilConfig := ethereum.DefaultEthereumAnvilChainConfig("ethereum") | |||
| anvilConfig := foundry.DefaultEthereumAnvilChainConfig("ethereum") | |||
There was a problem hiding this comment.
note to self:
- add release note that we support both foundry & geth now
modifications to local-ic required?nope you handled! ty!
| _, _, _ = val0.Exec(ctx, val0.TxCommand(keyName, command...), val0.Chain.Config().Env) | ||
| // We are running many nodes, using many resources. This function is similar to | ||
| // testutils.WaitForBlocks(), but does not hammer calls as fast as possible. | ||
| func NiceWaitForBlocks(ctx context.Context, delta int64, chain ibc.Chain) error { |
There was a problem hiding this comment.
nit: I like the idea for this function, but I think adding a time.Duration in the function params would be better suited so its more general? or maybe just a better name, as nice in what context to a user? Leaving that to scope for a future PR if desired.
WaitForBlocksWithDelay(ctx context.Context, delta int64, chain ibc.Chain, searchDelay time.Duration)
Reecepbcups
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested to also support Binance Smart Chain (v1.2.13)